-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Shell Command to support different shells and windows 10 sub linux system #20
base: master
Are you sure you want to change the base?
Conversation
Hey! thanks for the implementation :) I've downloaded the issue branch and linked it into atom. When I start atom I get the following error: Atom Version: 1.7.3 Stack TraceFailed to activate the linter-python package
Commands
Config{
"core": {
"disabledPackages": [
"linter-gcc",
"python-tools"
],
"packagesWithKeymapsDisabled": [
"spell-check"
]
},
"linter-python": {
"executablePath": "C:\\Python33\\Scripts\\pylama.exe",
"withPep257": true
}
} Installed Packages# User
autocomplete-paths, v1.0.2
hex, v0.6.2
keyboard-localization, v1.4.18
language-latex, v0.6.1
language-matlab, v0.2.1
latextools, v0.8.0
linter, v1.11.4
linter-eslint, v7.2.1
linter-matlab, v1.1.0
linter-python, v2.1.7
merge-conflicts, v1.4.2
minimap, v4.23.2
minimap-bookmarks, v0.3.0
minimap-cursorline, v0.1.0
minimap-find-and-replace, v4.5.1
minimap-linter, v1.1.1
minimap-selection, v4.4.0
pdf-view, v0.50.0
pigments, v0.26.0
preview-inline, v1.0.4
project-manager, v2.9.7
react, v0.15.0
release-notes, v0.53.0
sync-settings, v0.7.2
# Dev
No dev packages |
Have you run below commands from inside of downloaded repo?
I found one problem with your request: path handling from windows in linux. I have to read something about new windows future. |
I have linked but not installed, my bad 😭 I've never done this before. I'll try again later. |
I've added the shell command "bash -c" but the plugins throws an error:
Pylama path is left blank. |
I made some change in whole concept. Please update the plugin code and
My assumption is that python and pylama are installed on linux (bash) not in windows. Source code in other hand is available on windows file system. Please try and let me know. |
@pepjo Could you test last version of branch issue19? |
I had already replyed, I don't know why it's not posted :/ Your assumption is correct, I have pylama installed on linux (although right now I also have it on windows) I did try the last version and I get an error, either setting a path or not setting it. The error is:
Also, I've tried to add support for bash to another atom package and I found some wierd problems, you can read about them here: https://github.com/lsegal/atom-runner/issues/139#issuecomment-216037520 |
I have to check how atom/javascript are handling paths under Windows. |
Finally I had a time to install Atom under Windows. |
I checked the last version but It doesn't work. And there is no error neither with the red banner in atom or in the atom console. If I check "Linux on Windows" it does nothing, that's all :/ |
May I ask you to do one more test. Please select "Linux On Windows" and "debug" and try one more time. You should see many prints in dev tool console. |
I will postpone this feature until Windows update appears. |
Ok! I'm sorry I don't respond as fast I should :( Maybe it's a bit too late but here is the console log:
|
Provided debug log look almost ok. Command should be executed. The problem is why output or error doesn't appear? I'm using external lib to spawn the process. Maybe there is some problem. For sure I will back to this feature request after windows update. Thanks for tests. |
Is there any progress on this? |
Oh, this is just for linter-python. Darn. |
Hi, Is this still alive? Initially I installed the latest release from the Atom Package GUI and had an issue with linter-python not accepting "bash -c pylama"; after some googling I found watzon/wsl-proxy and implemented a
This is accepted only as a full path By accepted I mean that when I save, I don't get an error asking me to correct my pylama path... but what I find is nothing happens, i.e. no lints. BTW: The batch file works...
I stumbled across this PR, removed the general release and installed this version, by cloning locally and running Any ideas? |
Request from issue #19