Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR implements the possibility to manage some of the filebeat modules to be configured with this puppet module. The module currently only supports modules by giving the whole array to
filebeat::modules
. It also requires people to know the exact structure that it works.The new
filebeat::module::*
classes will abstract the structure and also perform correct datatype for each parameter. Beside this it also enables to setup modules based on the really installed services on a host if you define thefilebeat::module::*
in your profile / role files.e.g. we now can do in our
profile::redis
take care of the redis configuration and also includefilebeat::module::redis
without having to somehow pass it to thefilebeat::modules:
array.So far i only implemented modules used by us but implementation of the other filebeat modules would be possible and also custom modules will be possible if the module files (pipeline, dashboard etc.) are copied to the correct directory.
Best regards,
Stephan