Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Checking for NilClass #63

Closed
corey-hammerton opened this issue Nov 30, 2016 · 4 comments
Closed

Template Checking for NilClass #63

corey-hammerton opened this issue Nov 30, 2016 · 4 comments

Comments

@corey-hammerton
Copy link
Contributor

corey-hammerton commented Nov 30, 2016

In https://github.com/pcfens/puppet-filebeat/blob/master/templates/filebeat5.yml.erb#L34 it is currently checking if @filebeat_config['max_procs'] is :undef type, as seen below.

<%- if @filebeat_config['max_procs'] != :undef -%>

In all other if blocks they are checking for a nil value. For consistency's sake this :undef should be changed to nil.

This was uncovered after enabling the Future Parser on a Puppet 3.x environment.

@elconas
Copy link
Contributor

elconas commented Dec 6, 2016

Maybe this is fixed by #65

@corey-hammerton
Copy link
Contributor Author

@elconas it is not fixed in #65

@pcfens
Copy link
Owner

pcfens commented Jan 2, 2017

What's the specific error message you're getting for this? Originally this was set to nil, but another issue was encountered. It was fixed in 8e5bcf3.

@jarro2783
Copy link

I'm seeing this too. I don't know if it actually breaks anything. I suspect filebeat just uses the default value when this is empty. It would be nice not to have nil values set here though.

@pcfens pcfens closed this as completed in 47a608b Apr 4, 2017
pcfens added a commit that referenced this issue Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants