-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: set text size on resize event, not on paint event, to avoid 100% cpu #604
Conversation
This is a draft for now |
If the tests pass here, then something in #606 is breaking the suite. I have at least one guess already. |
I guess I'll be taking a stab at an independent "fix atef CI tests" PR. I'll start by comparing package versions. |
Do you mean typhos here? Or did something about atef die without me knowing? |
I meant typhos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
Move the dynamic text resizing to resize event so it doesn't happen every frame and use the entire cpu
Motivation and Context
https://jira.slac.stanford.edu/browse/ECS-5143
How Has This Been Tested?
Interactively to observe the usage
Tests slightly adjusted so they still pass (previously was looking for the paint event)
Where Has This Been Documented?
Here and in release notes
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page