Merge pull request #621 from ZLLentz/fix_combobox_resize_crash

FIX: formalize hotfix for resizing empty comboboxes
pcdshub · Oct 9, 2024 · 62aa6bc · 62aa6bc
2 parents 07fb0ed + f503653
commit 62aa6bc
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/docs/source/upcoming_release_notes/621-fix_combobox_resize_crash.rst b/docs/source/upcoming_release_notes/621-fix_combobox_resize_crash.rst
@@ -0,0 +1,23 @@
+621 fix_combobox_resize_crash
+#############################
+
+API Breaks
+----------
+- N/A
+
+Features
+--------
+- N/A
+
+Bugfixes
+--------
+- Fix an issue where dynamic font scaling applied to a combobox
+  with no entries would raise an exception and close typhos.
+
+Maintenance
+-----------
+- N/A
+
+Contributors
+------------
+- zllentz
diff --git a/typhos/dynamic_font.py b/typhos/dynamic_font.py
@@ -276,6 +276,8 @@ def set_font_size() -> None:
             )
             for text in combo_options
         ]
+        if not font_sizes:
+            return
         set_font_common(
             widget=widget,
             font_size=min(font_sizes),