-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi beamline #129
Multi beamline #129
Conversation
@@ -47,6 +47,30 @@ | |||
"invalid": true, | |||
"functional_group": "Vacuum", | |||
"location_group": "S 2" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know where this came from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is normal json, the diff just looks a little funny
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git decided that this was the new }
instead of the trailing one on line 74
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -47,6 +47,30 @@ | |||
"invalid": true, | |||
"functional_group": "Vacuum", | |||
"location_group": "S 2" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is normal json, the diff just looks a little funny
In a future version of lucid, the command-line args will go away entirely and everything will be in a config file that will implement both the toolbars and the hutch setup, among other things. For now, I think it's sufficient to support just one toolbar. |
@tangkong what input did you use to get that output? I usually see that when there are happi entries that don't have location groups defined. |
I guess I naively thought that |
I don't think it was naïve- lucid should do something smarter when the group designations are missing |
@@ -47,6 +47,30 @@ | |||
"invalid": true, | |||
"functional_group": "Vacuum", | |||
"location_group": "S 2" | |||
}, | |||
"TV5L0-VGC-1": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's up with this extra device in general? What is it used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I meant. I don't know where this device came from, but I guess its part of the demo database so I didn't look too much into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 👍 on this change, a little confused on the demo update
I agree with this statement, it's too ambiguous |
In launcher.py change the beamline argument to a list.
e.g. load beamline K3 for TXI: lucid K3
e.g. load beamline K3 and TXI: lucid K3 TXI
We should actually not use TXI as a beamline?
Tested by launching a screen using
lucid K3
andlucid K3 TXI