MNT: rename QtAds submodule to ads #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess it did not 🤷 |
|
I kind of want to slow down here because we still need to test that the update to v4 still has full compatibility from a user perspective |
|
This fails on conda for 3.8.2 (locally) but passes on pip for 3.8.1 on CI... |
|
Interactively this works more or less the same as it has always has, given the newer library installs |
ZLLentz
previously approved these changes
Oct 6, 2023
|
There is no pypi release of this package at version 4 |
ZLLentz
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect this to fail for pip, which still has pyqtads=3.8.1 as its most recent version (Assuming 4.0.0 changed the module naming, but release notes were less than helpful)