-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV/MNT: migrate to GitHub Actions and pyproject.toml [LCLSPC-603] #118
Conversation
Performed by pcds-migration-tools DeleteFiles
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools GitHubActionsMigration
Performed by pcds-migration-tools UpdateSphinx
Performed by pcds-migration-tools RunPyupgrade
Performed by pcds-migration-tools PyprojectTomlMigration
Performed by pcds-migration-tools SetuptoolsScmMigration
Performed by pcds-migration-tools UpdateCondaRecipe
Performed by pcds-migration-tools RunPycln
Performed by pcds-migration-tools RunPrecommit
Our old pip jobs in this repo were marked as allowed failures: https://github.com/pcdshub/lucid/runs/10858002940 (I think this is due to the old segfaulting issue we had?) Now pyqtads is causing failures in the pip test suite:
|
It's not obvious to me how to make pyqtads optional since it's used for the docking. I guess there'd just be an optional code path with no docking support? |
Yes, exactly @ZLLentz. It'd just be creating independent windows that can't be docked. It's either that or we just live with most of our CI jobs failing. |
It sounds kind of annoying to implement to me but maybe I haven't looked into it enough. It's a good idea if you think it's not too hard. |
Gave up on making pyqtads optional here, and as such I set pypi-backed jobs to be optional for PR CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, a shame the pyqtads stuff didn't pan out, but otherwise this seems standard.
conda-recipe/meta.yaml
Outdated
license: SLAC Open | ||
license_family: OTHER | ||
license_file: LICENSE.md | ||
summary: 'SLAC National Accelerator Laboratory: LCLS User Control and Interface Design' | ||
|
||
extra: | ||
recipe-maintainers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do our other projects have a recipe-maintainers section in their self-contained (non-forge) recipes? I don't remember seeing this outside of conda-forge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not typically, no - this probably could have been cleaned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in 29c75d1
Description
pyproject.toml
, replacingsetup.py
and related files.pyupgrade
.docs-versions-menu
replacesdoctr-versions-menu
anddoctr
usage for documentation deployment on GitHub Actions. The deployment key is now no longer required.pyupgrade
was used to update annotations, though there might not have been many herepycln
was used to clean up importsMotivation and Context
How Has This Been Tested?
Where Has This Been Documented?
This PR and Jira LCLSPC-603