Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add --skip_happi flag #117

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Conversation

tangkong
Copy link
Contributor

Description

adds --skip_happi flag to the lucid cli, defaulting to false. Allows lucid to be used for just the toolbar, rather than the grid of devices.

Context

closes #116

How has this been tested?

interactively

Copy link
Contributor

@klauer klauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LUCID itself is a larger mess than the above nitpicks, so in the interest of getting this deployed 👍 from me

lucid/launcher.py Show resolved Hide resolved
lucid/launcher.py Outdated Show resolved Hide resolved
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm interested to hear the story behind this one

@klauer
Copy link
Contributor

klauer commented Jan 31, 2023

I'm interested to hear the story behind this one

➡️ #116

@tangkong
Copy link
Contributor Author

I shall merge! This was a quick fix inspired by a detailed issue and stronger-than-usual cup of coffee.

@tangkong tangkong merged commit 75861b6 into pcdshub:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Flag to Skip Happi Beamline Loading
3 participants