Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAT590 Function block #91

Merged
merged 3 commits into from
Mar 17, 2022
Merged

VAT590 Function block #91

merged 3 commits into from
Mar 17, 2022

Conversation

janezg-SLAC
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to Always Newest version (Library, *)
  • Committed with pre-commit or ran pre-commit run --all-files

@Mbosum Mbosum requested review from jyin999 and Mbosum March 17, 2022 16:28
jyin999
jyin999 approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@jyin999 jyin999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VAT function need to be tested.

@jyin999 jyin999 merged commit c761509 into pcdshub:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyin999 jyin999 jyin999 approved these changes

@Mbosum Mbosum Awaiting requested review from Mbosum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janezg-SLAC @jyin999