Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Adding the MEG, LEG and HEG gratings in the ZO PMPS evaluation #134

Merged
merged 4 commits into from
Dec 3, 2024
Merged

DEV: Adding the MEG, LEG and HEG gratings in the ZO PMPS evaluation #134

merged 4 commits into from
Dec 3, 2024

Conversation

ghalym
Copy link
Collaborator

@ghalym ghalym commented Dec 3, 2024

Description

ECS-6938
Adding the MEG, LEG and HEG gratings in the ZO PMPS evaluation

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

patoppermann
patoppermann approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@patoppermann patoppermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now with the right unites.

@ghalym ghalym merged commit 9384c97 into pcdshub:master Dec 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patoppermann patoppermann patoppermann approved these changes

@jyotiphy jyotiphy Awaiting requested review from jyotiphy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghalym @patoppermann