Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add RangeConditionItem from #54 #60

Closed
wants to merge 1 commit into from

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Oct 17, 2024

Description

This adds the RangeConditionItem from #54 as-is

It doesn't work without the adjustments from #59
It needs to be revised in general because we weren't happy with it

We should do one of the following:

  • Expand the operator-based checks in place
  • Refactor the operator-based checks to use explicit function references

Motivation and Context

It's annoying to add three nodes for such a simple check, so this idiom generates the three nodes for me.

How Has This Been Tested?

Needs unit tests following rework

Where Has This Been Documented?

Later in pre-release notes

Pre-merge checklist

  • Code works interactively
  • Code follows the style guide
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@ZLLentz ZLLentz changed the title ENH: add RangeConditionItem from #54 (needs revisions) ENH: add RangeConditionItem from #54 Nov 1, 2024
@ZLLentz
Copy link
Member Author

ZLLentz commented Nov 1, 2024

Closing in favor of expanding the basic check nodes

@ZLLentz ZLLentz closed this Nov 1, 2024
@ZLLentz ZLLentz deleted the enh_range_checks branch November 1, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant