ENH: add RangeConditionItem from #54 #60
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the
RangeConditionItem
from #54 as-isIt doesn't work without the adjustments from #59
It needs to be revised in general because we weren't happy with it
We should do one of the following:
Motivation and Context
It's annoying to add three nodes for such a simple check, so this idiom generates the three nodes for me.
How Has This Been Tested?
Needs unit tests following rework
Where Has This Been Documented?
Later in pre-release notes
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page