-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcemaps #50
Comments
Took a stab at this here: https://github.com/duncanbeevers/handlebars-loader/tree/source-maps
|
@duncanbeevers this looks nice and simple, thank you for figuring out how to plumb all that. Can you submit it as a pull request? I think the only comment I'll have is to ask you to use node-semver to do the version comparison instead of manually parsing it. |
Thanks for the feedback. I originally wrote this using semver but wasn't sure about adding another dependency for such a minor comparison. I'll tuck that back in shortly. Do you have any opinion about the filepath stripping? I'm not all that familiar with gulp (or sourcemaps, for that matter) and wasn't sure about the right way to access that bit of info. |
@duncanbeevers is there any update on this? |
[email protected]
comes with support for sourcemaps. handlebars-lang/handlebars.js#902Any chance of supporting them in this plugin? If I open the hbs file in Chrome, I just see the compiled function (I suppose this allows debugging, but still)
The text was updated successfully, but these errors were encountered: