Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added executable scripts for benchmarks and stresstest #7

Merged
merged 23 commits into from
Apr 28, 2022
Merged

Conversation

lukas-mazur
Copy link
Contributor

Two executable scripts have been added in sub-folder bin/

  • bin/benchmarks: Performs all memory bandwidth and peakflop tests on all GPUs within a node
  • bin/stresstest: Performs stresstest on all GPUs within a node

Copy link
Collaborator

@carstenbauer carstenbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new io keyword arguments should ideally be documented (in the docstrings of the functions). At least for those functions, where we already have a list of keyword arguments.

I think the peakflops_gpu_wmmas and peakflops_gpu_fmas functions should also get the io keyword argument. (More generally, it's not ideal that we only introduce io for an rather arbitrary subset of the functions. E.g., the stresstest functions didn't get the new keyword for no apparent reason. But we can live with that of course.)

As for the logging stuff, I've never seriously used the Loggers before so I can't really comment on how to properly use them and I'm fine with the executable scripts as is. Let me note though that there certainly is a FileLogger or similar in the ecosystem as well (see, e.g., https://github.com/JuliaLogging/LoggingExtras.jl).

src/gpuinfo.jl Outdated Show resolved Hide resolved
bin/stresstest Outdated Show resolved Hide resolved
@lukas-mazur
Copy link
Contributor Author

@carstenbauer I agree with your points. I should have fixed now all the points you have mentioned. If I have missed something, please let me know.

@carstenbauer carstenbauer self-assigned this Apr 23, 2022
@carstenbauer carstenbauer merged commit 89120d0 into main Apr 28, 2022
@carstenbauer carstenbauer deleted the full_run branch April 28, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants