-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added executable scripts for benchmarks and stresstest #7
Conversation
…word parameter in gpuinfo.jl, host2device_bandwidth.jl and memory_bandwidth.jl
…nded executable script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new io
keyword arguments should ideally be documented (in the docstrings of the functions). At least for those functions, where we already have a list of keyword arguments.
I think the peakflops_gpu_wmmas
and peakflops_gpu_fmas
functions should also get the io
keyword argument. (More generally, it's not ideal that we only introduce io
for an rather arbitrary subset of the functions. E.g., the stresstest functions didn't get the new keyword for no apparent reason. But we can live with that of course.)
As for the logging stuff, I've never seriously used the Logger
s before so I can't really comment on how to properly use them and I'm fine with the executable scripts as is. Let me note though that there certainly is a FileLogger
or similar in the ecosystem as well (see, e.g., https://github.com/JuliaLogging/LoggingExtras.jl).
…now print into stdout.
@carstenbauer I agree with your points. I should have fixed now all the points you have mentioned. If I have missed something, please let me know. |
Two executable scripts have been added in sub-folder bin/