Apply current scope when initializing directive #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls $apply() when using interpolate to prevent the first input being dropped
|
Thanks for the PR! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem happens when using
interpolate/compile.Example w/ problem: http://plnkr.co/edit/HnWlthYQ2cPT39Xn9rjF?p=preview
Example fixed: http://plnkr.co/edit/eWa4js8kaR04ROesvayp?p=preview
My hljs directives weren't updating on the first event, so I noticed that the current code checks for
newVal !== oldValand for the first eventnewValis equals tooldVal, because the first render isn't applied using $digest, instead it is called directly with_elm.html(interpolateFn(_interpolateScope));.Hope this help :)
Bonus: I also dropped unused
$logdependency