GCloud state backend: coding style fixes #1
Conversation
Many GCS errors are returned by Close(), but not all.
Refactorings to make the code more idiomatic.
| @@ -58,11 +58,14 @@ func (b *Backend) configure(ctx context.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| data := schema.FromContextBackendConfig(ctx) | |||
| // ctx is a background context with the backend config added. | |||
| // Since no context is passed to RemoteClient.Get(), .Lock(), etc. we | |||
There was a problem hiding this comment.
This comment seems to be truncated
There was a problem hiding this comment.
D'oh, thanks for noticing. I'll update my branch in a second :)
Calling context.Background() from outside the main() function is discouraged. The configure functions are only called from "…/helper/schema".Backend.Configure which provides the Background context, i.e. a long-living context we can use for backend communication.
This allows Unlock() to call Delete() without reading the lock file's content first.
|
There, comment is fixed now :) You mentioned that you're new to Go. Would you prefer if I left review comments to get the code into a more idiomatic Go form as a sort of learning experience or should I continue to just fix it and send PRs? Best regards, |
|
I would like to slow you down - I can learn from the diffs too :) Is the PR ready to be merged or are you going to push more fixes to make the code look more idiomatic? |
|
I'm sure there will be more patches in the future, but that'll be it for today. I'll likely be able to spend some more time on this tomorrow :) Feel free to merge at your convenience, I can always create another PR ;) |
|
Thank you for all the improvements @octo! By the way, would you like to take a look at changes required to make the new backend compatible with the existing I will definitely spend some time on it but not earlier than next week. |
|
Yes, I'll take a look at that tomorrow. Thank you for your PR, it's looking great so far :) |
|
I am facing an issue in which when I try to initialize Terragrunt I am receiving this error Error: Error locking state: Error acquiring the state lock: writing "gs:///default.tflock" failed: googleapi: Error 412: Precondition Failed, conditionNotMet I am using terraform v0.11.15-oci and Terrafrunt 0.18.7 Request you to assist on the same |
Here are my changes to the GCloud implementation, as mentioned in hashicorp#15592.
Noteworthy changes are:
Unlock()to call "delete if generation matches" immediately, removing one round-trip.configure()callback to avoid callingcontext.Background().Any feedback is welcome :)
Best regards,
—octo