Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

another fix to bobbit's IRC maximum message length #82

Open
wants to merge 2 commits into
base: bobbit-0.2.x
Choose a base branch
from
Open

another fix to bobbit's IRC maximum message length #82

wants to merge 2 commits into from

Commits on Feb 23, 2024

  1. use length in bytes of message/command to determine when to wrap IRC … 

    …messages

previously, we used len(message)/len(command) to determine when to wrap, but that doesn't necessarily correlate to the number of bytes, which is what the IRC spec cares about
    @antithalian
    antithalian committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b00a812 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. changes bobbit to use a more conservative max message length for IRC 

    IRC messages can be at most 512 bytes, including the sender's hostmask

determining the hostmask 100% accurately before sending each message is hard, so setting a conservative max length makes the most sense
    @antithalian
    antithalian committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    50a0d39 View commit details
    Browse the repository at this point in the history