Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apm): adding paidy logo #84

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

sathyashyam2406
Copy link
Contributor

Added Paidy Logo
Bump sdk-constants related PR, paypal/paypal-sdk-constants#112

JIRA: https://engineering.paypalcorp.com/jira/browse/DTALTPBLR-756

Tested locally with checkout components

image

Figma Dashboard link

image

@sathyashyam2406 sathyashyam2406 requested a review from a team as a code owner January 4, 2023 08:32
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 66.83% // Head: 67.64% // Increases project coverage by +0.81% 🎉

Coverage data is based on head (af988d3) compared to base (94cc5ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   66.83%   67.64%   +0.81%     
==========================================
  Files          40       41       +1     
  Lines         199      204       +5     
  Branches       33       34       +1     
==========================================
+ Hits          133      138       +5     
  Misses         64       64              
  Partials        2        2              
Impacted Files Coverage Δ
src/constants.js 100.00% <ø> (ø)
src/logos/paidy/logo.jsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gregjopa
Copy link
Contributor

gregjopa commented Jan 4, 2023

Hi @sathyashyam2406, has the Design team signed off on this? I'm unable to access the Figma mockup. The "Pay with paidy Paidy" text seems redundant.

@sathyashyam2406
Copy link
Contributor Author

Hi @sathyashyam2406, has the Design team signed off on this? I'm unable to access the Figma mockup. The "Pay with paidy Paidy" text seems redundant.

Hi @gregjopa,

  1. Have send mail to design team to provide sign-off. Will update you once received.
  2. Have sent invite for you to access the Figma mock up. Please try and let me know.
  3. "Pay with paidy Paidy" will be like "Pay with Paidylogo + Paidy text" which is implemented for all other APMs. PFA screenshot for your reference for other APMs
    image

@sathyashyam2406
Copy link
Contributor Author

Hi @sathyashyam2406, has the Design team signed off on this? I'm unable to access the Figma mockup. The "Pay with paidy Paidy" text seems redundant.

Hi @gregjopa,

  1. Have send mail to design team to provide sign-off. Will update you once received.
  2. Have sent invite for you to access the Figma mock up. Please try and let me know.
  3. "Pay with paidy Paidy" will be like "Pay with Paidylogo + Paidy text" which is implemented for all other APMs. PFA screenshot for your reference for other APMs
    image

Hi @gregjopa,
We have got signoff from the design team. Have copied you in the mail thread.
Also for the "Pay with Paidylogo + Paidy text", design team mentioned it's good as of now.

@dtjones404 dtjones404 merged commit 3bac6bd into paypal:main Jan 9, 2023
@gregjopa gregjopa mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants