-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DTPP-142] PayPalWebPayments show stages of order #311
[DTPP-142] PayPalWebPayments show stages of order #311
Conversation
Demo/Demo/CardPayments/CardPaymentViewModel/CardPaymentState.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebPaymentsView/PayPalWebCreateOrderView.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebPaymentsView/PayPalWebResultView.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/CardPayments/CardPaymentViewModel/CardPaymentState.swift
Outdated
Show resolved
Hide resolved
Pressing on PayPal checkout button is stuck in loading indicator of Create order button. I'll take a closer look at what's going on. |
Demo/Demo/PayPalWebPayments/PayPalWebPaymentsView/PayPalWebButtonsView.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
I'm trying to figure out why your result views for order completion is not appearing while it is working on main. |
Ah, that was actually something I was planning to refactor yesterday. Right, the orderId is no longer used, and we need to remove a check from there. |
Demo/Demo/PayPalWebPayments/PayPalWebPaymentsView/PayPalWebTransactionView.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
The loading indicator wasn’t showing because it was tracking the orderID computed property, but it wasn’t assigned in the ViewModel and was always nil. I’ll push a commit to set the orderID The approve result view is not appearing because the state for approveResultResponse always defaults to idle instead of transitioning to loaded. I'm looking into that. |
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
Hey Georgi, it looks good so far, just doing some testing. Can you order the views in order they appear? |
Demo/Demo/PayPalWebPayments/PayPalWebViewModel/PayPalWebViewModel.swift
Outdated
Show resolved
Hide resolved
🎉 Great job Georgi! |
Reason for changes
Summary of changes
Refactored PaypalWebViewModel for better state tracking, updated PayPalButtonsView for progress handling, and fixed successView display issue.
Checklist
Authors