DTPP-11 Demo app organize folder structure #307
Conversation
Demo/Demo.xcodeproj/project.pbxproj
Outdated
| children = ( | ||
| 3BB60B542B1FA00C00A298CF /* PayPalVaultViewModel.swift */, | ||
| 3BA0A58A2B1E240300330681 /* VaultViewModel.swift */, | ||
| 3B2027402A8A72050007907E /* VaultState.swift */, |
There was a problem hiding this comment.
VaultViewModel is a parent class and VaultState is a published state in VaultViewModel, maybe they could be in their own folder along with common vault views - the ones that are done on merchant server?
There was a problem hiding this comment.
The PayPalVault -> PayPalVaultViewModel => VaultState, VaultViewModel
PayPalVault -> views under VaultViews, these are common views for merchant side set up for all vault flows.
Could go under just "Vault" folder
There was a problem hiding this comment.
oh I meant outside of the PayPalVault folder. Maybe just "Vault" folder with view models and views. There is PayPal vault, Card vault and other payment methods in the future.
And how about we order the views in sequence of expected events of the main view?
There was a problem hiding this comment.
so for example under CardPayments, there are container views like CardPaymentView (which is not a good name, originally it was going to be container view for all the subviews like in CardVault) which has create order, order result result, the SDK portion, approve and result and container view for order completion with capture/authorize and result view
There was a problem hiding this comment.
so for example under CardPayments, there are container views like CardPaymentView (which is not a good name, originally it was going to be container view for all the subviews like in CardVault) which has create order, order result result, the SDK portion, approve and result and container view for order completion with capture/authorize and result view
maybe i can change the name to CardViewComponents or CardPaymentsScreens ?
There was a problem hiding this comment.
CardPaymentView => that actually is the main container view.
CreateOrderCardPaymentView
OrderCreateCardResultView
CardOrderApproveView
CardApprovalResultView
CardPaymentOrderCompletionView
CardOrderActionButton
CardOrderCompletionResultView
There was a problem hiding this comment.
I think CardPaymentView is ok, consistent with PayPalVaultView. I like CardPaymentsScreens ✅.
but we have PayPalWebButtonsView as main container view in PayPalWebPaymentsView.
There was a problem hiding this comment.
Not too particular, I think having the correct order would make it easier to read.
There was a problem hiding this comment.
Sure! I prefer CardPaymentsScreens over CardViewComponents because it's clearer about which module the container view is for. And that view, imo should be at the very top of the view folder.
|
Looks so clean! Let me test things out, just to make sure nothing is missing and will give it a ✅ |
|
Looks great Georgi! 🎉 |
Reason for changes
Organize folder structure
Summary of changes
Checklist