[PART 2] Networking Refactor - Unify REST & GraphQL networking implementation
#182
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import Foundation | ||
|
|
||
| /// Used to parse error message details out of GraphQL HTTP response body | ||
| struct GraphQLErrorResponse: Decodable { | ||
|
|
||
| enum CodingKeys: String, CodingKey { | ||
| case error = "error" | ||
| case correlationID = "correlation_id" | ||
| } | ||
|
|
||
| let error: String | ||
| let correlationID: String? | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import Foundation | ||
|
|
||
| /// The GraphQL query and variable details encoded to be sent in the POST body of a HTTP request | ||
| struct GraphQLHTTPPostBody: Encodable { | ||
|
|
||
| let query: String | ||
| let variables: Data | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /// Used to decode the HTTP reponse body of GraphQL requests | ||
| struct GraphQLHTTPResponse<T: Codable>: Codable { | ||
|
|
||
| let data: T? | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import Foundation | ||
|
|
||
| /// :nodoc: Values needed to initiate a GraphQL network request | ||
| public struct GraphQLRequest { | ||
|
|
||
| let query: String | ||
| let variables: Data | ||
|
|
||
| /// This is non-standard in the GraphQL language, but sometimes required by PayPal's GraphQL API. | ||
| /// Some requests are sent to `https://www.api.paypal.com/graphql?<queryNameForURL>` | ||
| let queryNameForURL: String? | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import Foundation | ||
|
|
||
| /// :nodoc: Values needed to initiate a HTTP network request | ||
| public struct HTTPRequest { | ||
|
|
||
| let headers: [HTTPHeader: String] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ public class HTTPResponseParser { | |
| decoder.keyDecodingStrategy = .convertFromSnakeCase | ||
| } | ||
|
|
||
| // TODO: - Update this func (or file) to handle both GraphQL and REST error parsing | ||
| public func parse<T: Decodable>(_ httpResponse: HTTPResponse, as type: T.Type) throws -> T { | ||
| guard let data = httpResponse.body else { | ||
| throw APIClientError.noResponseDataError | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!