improve button accessibility #2156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the
aria-labelfrom the top level button container to the lower levelspanthat wraps both thelabeland thelogo.Why are we making these changes?
Today when a screen reader focuses on a button with a label, the text is read aloud as just "PayPal". This change (plus the sdk-logos change) will read the button text aloud with the label, e.g. "Pay with PayPal":
Screen.Recording.2023-05-01.at.12.00.11.mov
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
There will also be a PR incoming for sdk-logos. I will update this PR once that one is open.
Groups who should review (if applicable)
❤️ Thank you!