Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: Fix SDK Version Bug #304

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Conversation

sshropshire
Copy link
Collaborator

Summary of changes

  • This PR fixes a bug in our Gradle file that tries to inject an environment variable that doesn't exist
  • We should use rootProject.version going forward instead of versionName

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire marked this pull request as ready for review December 3, 2024 21:10
@sshropshire sshropshire requested a review from a team as a code owner December 3, 2024 21:10
@KunJeongPark
Copy link
Collaborator

KunJeongPark commented Dec 3, 2024

Did you check Notebooks to see analytics output?

@sshropshire
Copy link
Collaborator Author

Did you check Notebooks to see analytics output?

@KunJeongPark I can, I haven't verified end-to-end yet.

@sshropshire
Copy link
Collaborator Author

@KunJeongPark I was able to verify and also ended up adding another revision to send all analytics to the LIVE environment so they can be tracked. Great catch!

@sshropshire sshropshire merged commit d6028a0 into main Dec 4, 2024
6 checks passed
@sshropshire sshropshire deleted the analytics_send_correct_version_id branch December 4, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants