Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CardClient Analytics Logic Into CardAnalytics Class #297

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Migrate CardClient Analytics Logic Into CardAnalytics Class #297

merged 8 commits into from
Nov 25, 2024

Conversation

sshropshire
Copy link
Collaborator

@sshropshire sshropshire commented Nov 25, 2024 •
edited
Loading

Summary of changes

  • This PR creates a CardAnalytics class to encapsulate analytics notification logic
  • Externalizing Analytics code should make Analytics Events easier to audit in one place
  • Externalizing Analytics will also make future refactoring to migrate away from the listener pattern more clear

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire changed the title Create CardAnalytics Migrate CardClient Analytics Logic Into CardAnalytics Class Nov 25, 2024
@sshropshire sshropshire marked this pull request as ready for review November 25, 2024 19:13
@sshropshire sshropshire requested a review from a team as a code owner November 25, 2024 19:13
@KunJeongPark
Copy link
Collaborator

Very clean, I like how it forces us to be clear about our messages.

@sshropshire sshropshire merged commit 6ac1752 into main Nov 25, 2024
6 checks passed
@sshropshire sshropshire deleted the card_analyitcs branch November 25, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KunJeongPark KunJeongPark KunJeongPark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshropshire @KunJeongPark