Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Version Catalog #277

Merged
merged 25 commits into from
Oct 23, 2024
Merged

Update to Version Catalog #277

merged 25 commits into from
Oct 23, 2024

Conversation

sshropshire
Copy link
Collaborator

Summary of changes

  • This PR is to modernize our Gradle configuration by migrating to Version Catalogs as recommended by Google
  • The naming convention for naming dependencies in the version catalog is loosely based on this set of best practices, though it's worth revisiting

Checklist

  • [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire
Create libs.versions.toml file and migrate kotlin stdlib.
bbc428c
@sshropshire
Migrate additional libraries to version catalog.
9ee590b
@sshropshire
Migrate appcompat dependency to version catalog.
1efaad1
@sshropshire
Update version catalog to include androidx compose libraries.
b31f0cd
@sshropshire
Migrate additional jetpack compose libraries to version catalog.
eec87e5
@sshropshire
Migrate jetpack preference lib to reference catalog.
dc08b58
@sshropshire
Migrate square dependencies to version catalog.
cac06f4
@sshropshire
Migrate square libs to version catalog.
d9b44ed
@sshropshire
Migrate browser switch to version catalog.
8e75133
@sshropshire
Migrate test dependencies to version catalog.
72a201b
@sshropshire
Migrate native checkout dependencies to version catalog.
87c1989
@sshropshire
Migrate some plugins over to version catalogs.
4680a5c
@sshropshire
Migrate dagger hilt to version catalog.
11e471b
@sshropshire
Migrate jacoco to version catalog.
bf5ed7e
@sshropshire
Remove build.gradle configuration that's no longer needed.
badb181
@sshropshire
Remove subprojects block.
111579f
@sshropshire
Migrate kotlin parcelize to version catalog.
8a4e7e2
@sshropshire
Migrate to alias.
c05fd63
@sshropshire
Clean up version catalog unused dependencies.
b16e024
@sshropshire
Sort version dependencies in alphabetical order.
8649a27
@sshropshire
Adjust verion catalog naming similar to ref: https://blog.gradle.org/…
273840a 
…best-practices-naming-version-catalog-entries.
@sshropshire
Update naming of plugins.
ba759da
@sshropshire sshropshire requested a review from a team as a code owner October 18, 2024 20:36
@KunJeongPark
Copy link
Collaborator

Did you observe any changes in build times or CI/CD performance after this PR?

@sshropshire
Copy link
Collaborator Author

Did you observe any changes in build times or CI/CD performance after this PR?

Nothing noticeable. This is primarily a best practice recommendation by Google and it cleans up our Gradle config a bit.

KunJeongPark
KunJeongPark approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@KunJeongPark KunJeongPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sshropshire sshropshire merged commit 6f08694 into main Oct 23, 2024
7 checks passed
@sshropshire sshropshire deleted the update_to_version_catalog branch October 23, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KunJeongPark KunJeongPark KunJeongPark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshropshire @KunJeongPark