Google Play store compliance fix #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating package name of dependencies.
tdchow
reviewed
Apr 17, 2024
...ayments/src/main/java/com/paypal/android/paypalnativepayments/PayPalNativeCheckoutRequest.kt
Show resolved
Hide resolved
tdchow
approved these changes
Apr 17, 2024
agedd
reviewed
Apr 18, 2024
| @@ -77,7 +77,7 @@ buildscript { | |||
| "json" : "org.json:json:20220320", | |||
|
|
|||
| // PayPal | |||
| "nativeCheckout" : "com.paypal.checkout:android-sdk:1.2.1", | |||
| "nativeCheckout" : "com.paypal.checkout:android-sdk:1.3.2", | |||
There was a problem hiding this comment.
qq here - should this be version 1.3.0, that's the latest release i'm seeing here
Suggested change
| "nativeCheckout" : "com.paypal.checkout:android-sdk:1.3.2", | |
| "nativeCheckout" : "com.paypal.checkout:android-sdk:1.3.0", |
There was a problem hiding this comment.
hmmm.. great catch.
I feel the latest version might not have been tagged in the releases.
@tdchow please correct me if I'm wrong, but I believe 1.3.2 is the latest that we had to consume, correct?
There was a problem hiding this comment.
Yep, it looks like the latest versions have not been tagged in the GitHub releases. The correct version to use is 1.3.2.
https://repo1.maven.org/maven2/com/paypal/checkout/android-sdk/1.3.2/
agedd
reviewed
Apr 18, 2024
| * Create `PayPalDataCollectorRequest` | ||
| * Add `PayPalDataCollector#collectDeviceData(context, request)` | ||
| * Deprecate `PayPalDataCollector#collectDeviceData(context, clientMetadataId, additionalData)` | ||
| * PayPalNativePayments | ||
| * Fixes Google Play Store Rejection | ||
| * Bump Native Checkout version to 1.3.2 |
There was a problem hiding this comment.
nit: same comment as below
Suggested change
| * Bump Native Checkout version to 1.3.2 | |
| * Bump Native Checkout version to 1.3.0 |
agedd
approved these changes
Apr 18, 2024
KunJeongPark
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
magnessdkto 5.5.1.Checklist
Authors