[Docs] Add Cardinal SDK Code Snippet for Top-level build.gradle File #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxdesmarais
approved these changes
Oct 12, 2023
Co-authored-by: Devon Apple (PayPal) <[email protected]>
sarahkoop
reviewed
Oct 12, 2023
| @@ -21,14 +21,30 @@ The order created on your server will be used to authorize or capture funds. For | |||
|
|
|||
| ### 1. Add the PayPal Native Payments module to your app | |||
|
|
|||
| In your `build.gradle` file, add the following dependency: | |||
| In your app's `build.gradle` file, add the following dependency: | |||
There was a problem hiding this comment.
I think with newer gradle versions / new project setups it's recommended that this goes in settings.gradle. Not sure if we want to differ from existing docs here but could update all our docs around Cardinal inclusion to be more modern (ref: https://saucelabs.com/resources/blog/how-to-prefer-settings-gradle-repositories-over-build-gradle). Either way is fine by me
There was a problem hiding this comment.
We should go for the newer way eventually. I've always been hesitant to update build.gradle files but it's something we should definitely address to make sure we're aligned with Android best practices.
sarahkoop
approved these changes
Oct 12, 2023
sshropshire
deleted the
update_mxo_docs_to_include_cardinal_sdk_code_snippet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
build.gradlePayPalNativePaymentsmoduleChecklist
- [ ] Added a changelog entryAuthors