Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo: Remove Approve Order Progress Fragment #180

Merged
merged 28 commits into from
Aug 29, 2023
Merged

Demo: Remove Approve Order Progress Fragment #180

merged 28 commits into from
Aug 29, 2023

Conversation

sshropshire
Copy link
Collaborator

@sshropshire sshropshire commented Aug 21, 2023 •
edited
Loading

Summary of changes

  • Remove ApproveOrderProgressFragment
  • Refactor CardFragment to streamline UX
screen-20230824-122420.mp4

Checklist

- [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire
Extract create order form.
6ac918b
@sshropshire
Use new CreateOrder form on CreateOrder fragment.
6464cf6
@sshropshire
Remove unecessary annotation on create order fragment page.
b98d33b
@sshropshire
Remove Feature enum from CardFragment.
b8016a8
@sshropshire
Go directly to CardFragment for ApproveOrder flow.
786e166
@sshropshire
Require a title for the Create Order form.
91cc137
@sshropshire
Add ApproveOrderForm.
a1d8657
@sshropshire
Update Approve Order Result to display 3DS success.
9d389c2
@sshropshire
Implement Complete Order Form.
fa8c0e3
@sshropshire
Add launched effect to CardFragment.
031f8f6
@sshropshire
Add log statements for CardFragment 3DS events.
7874e63
@sshropshire
Show approve order errors when appropriate.
db0af5b
@sshropshire
Remove ApproveOrderProgressFragment from the nav graph.
9080086
@sshropshire
Remove ApproveOrderProgressFragment.
7d06687
@sshropshire
Remove ApproveOrderProgressViewModel.
bed5f40
@sshropshire
Remove ApproveOrderEvent type.
3fa51a6
@sshropshire
Remove ComposableEvent type.
77c4abf
@sshropshire
Move ApproveOrderSuccessView.kt to ui.card package.
df87d38
@sshropshire
Fix typo.
1acc4b7
@sshropshire
Remove GetOrderView.
f4e1a76
@sshropshire
Move MessageView to ui.shared package.
1b221d6
@sshropshire
Move OrderCompleteView to ui.card package.
fb69e39
@sshropshire
Fix package import issues.
1d76d30
@sshropshire
Cleanup lint errors.
434d89f
@sshropshire
Cleanup lint errors.
415c3e2
@sshropshire
Add PayPalClientMetadataId to complete order method.
80c4c0e
@sshropshire
Update UI test for approve order.
3427ff9
@sshropshire
Fix lint errors.
043c5c0
@sshropshire sshropshire force-pushed the remove_approve_order_progress_fragment branch from 0c54540 to 043c5c0 Compare August 24, 2023 15:31
@sshropshire sshropshire marked this pull request as ready for review August 24, 2023 17:27
@sshropshire sshropshire requested a review from a team as a code owner August 24, 2023 17:27
@sshropshire sshropshire removed the DRAFT label Aug 24, 2023
sarahkoop
sarahkoop approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@sarahkoop sarahkoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sshropshire sshropshire merged commit 7dd1ef8 into main Aug 29, 2023
6 checks passed
@sshropshire sshropshire deleted the remove_approve_order_progress_fragment branch August 29, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkoop sarahkoop sarahkoop approved these changes

@KunJeongPark KunJeongPark KunJeongPark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sshropshire @KunJeongPark @sarahkoop