-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FraudProtection Docs #176
Conversation
Demo/src/main/java/com/paypal/android/ui/approveorderprogress/ApproveOrderProgressFragment.kt
Outdated
Show resolved
Hide resolved
PaypalDataCollectorEnvironment
EnumFraudProtection
Remove PaypalDataCollectorEnvironment
Enum
FraudProtection
Remove PaypalDataCollectorEnvironment
EnumFraudProtection
Docs and Remove PaypalDataCollectorEnvironment
Enum
FraudProtection
Docs and Remove PaypalDataCollectorEnvironment
Enum@@ -40,7 +40,7 @@ dependencies { | |||
implementation files('libs/android-magnessdk-5.3.0.jar') | |||
} | |||
|
|||
|
|||
api project(':CorePayments') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this works the same on the Android side but should we call out this dependency in the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we don't usually mention dependency additions on Android since they're declared in the Gradle file and become transitive dependencies in a merchant project. How do y'all do it on iOS?
when (config.environment) { | ||
com.paypal.android.corepayments.Environment.LIVE -> Environment.LIVE | ||
com.paypal.android.corepayments.Environment.SANDBOX -> Environment.SANDBOX | ||
com.paypal.android.corepayments.Environment.STAGING -> Environment.STAGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a follow up ticket to remove staging from Android for parity across platforms? I don't think we've ever used it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 literally just saw you have another PR to do exactly this. Ignore me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is a holdover from another PR. They were created around the same time we realized we need to remove staging.
39b625c
to
c6bf517
Compare
…ure and authorize methods.
e7e140c
to
2d31aeb
Compare
Summary of changes
FraudProtection
modulePayPalDataCollector
constructor to require a configuration instead of an environmentPayPalDataCollectorEnvironment
enumChecklist
Authors