Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FraudProtection Docs #176

Merged
merged 18 commits into from
Aug 22, 2023
Merged

Add FraudProtection Docs #176

merged 18 commits into from
Aug 22, 2023

Conversation

sshropshire
Copy link
Collaborator

@sshropshire sshropshire commented Aug 14, 2023

Summary of changes

  • Add docs for FraudProtection module
  • Breaking Changes
    • FraudProtection
      • Update PayPalDataCollector constructor to require a configuration instead of an environment
      • Remove PayPalDataCollectorEnvironment enum
  • iOS Equivalent PR: Add FraudProtection Docs paypal-ios#184

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire requested a review from a team as a code owner August 14, 2023 19:52
CHANGELOG.md Outdated Show resolved Hide resolved
@sshropshire sshropshire changed the title Remove PaypalDataCollectorEnvironment Enum Add FraudProtection Remove PaypalDataCollectorEnvironment Enum Aug 15, 2023
@sshropshire sshropshire changed the title Add FraudProtection Remove PaypalDataCollectorEnvironment Enum Add FraudProtection Docs and Remove PaypalDataCollectorEnvironment Enum Aug 15, 2023
@sshropshire sshropshire changed the title Add FraudProtection Docs and Remove PaypalDataCollectorEnvironment Enum Add FraudProtection Docs Aug 15, 2023
@@ -40,7 +40,7 @@ dependencies {
implementation files('libs/android-magnessdk-5.3.0.jar')
}


api project(':CorePayments')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this works the same on the Android side but should we call out this dependency in the changelog?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we don't usually mention dependency additions on Android since they're declared in the Gradle file and become transitive dependencies in a merchant project. How do y'all do it on iOS?

when (config.environment) {
com.paypal.android.corepayments.Environment.LIVE -> Environment.LIVE
com.paypal.android.corepayments.Environment.SANDBOX -> Environment.SANDBOX
com.paypal.android.corepayments.Environment.STAGING -> Environment.STAGE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a follow up ticket to remove staging from Android for parity across platforms? I don't think we've ever used it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 literally just saw you have another PR to do exactly this. Ignore me!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a holdover from another PR. They were created around the same time we realized we need to remove staging.

@sshropshire sshropshire merged commit 1fc37a3 into main Aug 22, 2023
6 checks passed
@sshropshire sshropshire deleted the paypal_data_collector branch August 22, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants