Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

fix(locale): added 'locale' information in payload.findByID #31

Merged
merged 8 commits into from
May 15, 2023

Conversation

finkinfridom
Copy link
Contributor

  • locale info is not used when querying forms entities. This may lead to unwanted scenarios (e.g. sending emails with wrong labels)
  • In case of errors, the nested properties (e.g. response.body.errors) are not properly stringified and it's almost impossible to identify the issue. Now the detail is more verbose but should help troubleshooting.

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@jacobsfletch jacobsfletch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes need here, but overall great work and thank you for your effort!

@jacobsfletch jacobsfletch linked an issue May 11, 2023 that may be closed by this pull request
@finkinfridom
Copy link
Contributor Author

hey @jacobsfletch all changes have been applied.
Thanks for the review

@finkinfridom finkinfridom requested a review from jacobsfletch May 12, 2023 06:24
@jacobsfletch
Copy link
Member

@finkinfridom good work! One last thing, though, it looks like you have eslint or prettier running which has linted that file unexpectedly. Can you do one last push here to only include the lines that need to change? We should get some linting setup for this project but that should be separate work from this.

@finkinfridom
Copy link
Contributor Author

@jacobsfletch done!

@jacobsfletch jacobsfletch merged commit 7531c10 into payloadcms:main May 15, 2023
@jacobsfletch
Copy link
Member

Amazing. THANK YOU!! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization is not managed in sendEmail process
2 participants