Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply receiver Well Known Errrors #53

Closed
DanGould opened this issue Apr 15, 2023 · 0 comments · Fixed by #120
Closed

Supply receiver Well Known Errrors #53

DanGould opened this issue Apr 15, 2023 · 0 comments · Fixed by #120
Labels
api enhancement New feature or request help wanted Extra attention is needed send sending payjoin
Milestone
payjoin-1.0

Comments

@DanGould
Copy link
Contributor

DanGould commented Apr 15, 2023 •
edited
Loading

Right now process_response only decodes a successful PSBT which it validates. Error response bodies should also be parsed to be displayed safely to end users. As specified in the well known errors section of BIP 78.

Errors from process_response may be improved by being separated into safe ReceiverError::WellKnown standard error types that can be displayed in the UI and ReceiverError::DebugOnly which "can only appear in debug logs." Separation would simplify an integration's error handling.
@DanGould DanGould added the enhancement New feature or request label Apr 15, 2023
@DanGould DanGould mentioned this issue Apr 15, 2023
Merged
@DanGould DanGould added the receive receiving payjoin label May 27, 2023
@DanGould DanGould added this to the 0.10.0 milestone Jul 31, 2023
@DanGould DanGould added api help wanted Extra attention is needed labels Sep 28, 2023
@DanGould DanGould mentioned this issue Oct 17, 2023
Closed
2 tasks
@jbesraa jbesraa mentioned this issue Nov 28, 2023
Merged
@DanGould DanGould added send sending payjoin and removed receive receiving payjoin labels Dec 13, 2023
DanGould added a commit that referenced this issue Dec 27, 2023
@DanGould
Supply & parse receiver response errors (#120)
8ffa8ef 
supersedes #110

resolves #53
@github-project-automation github-project-automation bot moved this from Todo to Done in Payjoin Roadmap 📝 Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api enhancement New feature or request help wanted Extra attention is needed send sending payjoin
Projects
Payjoin Roadmap 📝
Status: Done
Milestone
payjoin-1.0
1 participant
@DanGould