Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct Uri from Enrolled method #205

Closed
DanGould opened this issue Mar 8, 2024 · 0 comments · Fixed by #283
Closed

Construct Uri from Enrolled method #205

DanGould opened this issue Mar 8, 2024 · 0 comments · Fixed by #283
Labels
api receive receiving payjoin

Comments

@DanGould
Copy link
Contributor

DanGould commented Mar 8, 2024

Enrolled should have all of the configuration and state necessary to return a Uri. This should enable removal of the less clear pubkey, fallback_target functions.

This allows construct_pj_uri can to be removed from the v2 cli and any similar function from downstream implementation.

Manual construction is particularly annoying because OhttpKeys is required for the enroller and then again for the Uri, and it'd have to be cloned in the Uri without this convenience function.

@DanGould DanGould added receive receiving payjoin api labels Mar 8, 2024
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Apr 28, 2024
@DanGould DanGould added this to the payjoin-0.18.0 milestone Jun 17, 2024
@DanGould DanGould mentioned this issue Jun 24, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api receive receiving payjoin
Projects
None yet
1 participant