Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon and another experimental warning #49

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

nickfarrow
Copy link
Collaborator

No description provided.

<title>nolooking // Lightning PayJoin</title>
</head>
<body dark-mode>
<br>
<br>
<header class="center">
<h1>👻 &nbsp;Lightning PayJoin&nbsp; 👻</h1>
<a href="https://nolooking.chaincase.app/" target="_blank" style="text-decoration:none"><h1>👻 &nbsp;Lightning PayJoin&nbsp; 👻</h1></a>
Copy link
Contributor

@DanGould DanGould Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading this makes me realize 👻 &nbsp;Lightning PayJoin&nbsp; 👻 is messy. Should be <span class="h1">👻 &nbsp;<h1>Lightning PayJoin</h1>&nbsp; 👻</span> for proper semantics with the --h1 css variables, but it's past halloween anyway to get rid of this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't manage to make this change without getting them onto new lines

@@ -58,6 +59,7 @@ <h2>Queue batches of lightning channels to open in a single transaction</h2>
</div>
<output id="queued" class="invisible">
<h2>PayJoin here to open these channels</h2>
<code style="text-align: center;">⚠ This software is still extremely experimental and has not been vetted, use at your own risk ⚠</code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not code. best to save semantic elements for semantics and use styles to apply styles

Copy link
Collaborator Author

@nickfarrow nickfarrow Nov 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True lazy mans HTML 😅
i love the default code style ahaha, abuse it on so many sites

Will resolve

Copy link
Contributor

@DanGould DanGould Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it <code> just font-family: monospace ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It adds border and some other cool styling (put important bits in .warning css class)

@DanGould
Copy link
Contributor

DanGould commented Nov 5, 2022

ghost seems seasonal. Can we use the umbrel app icon.svg for favicon?

@DanGould
Copy link
Contributor

DanGould commented Nov 7, 2022

Favicons based on umbrel icon: favicon_package_v0.16.zip

@DanGould DanGould merged commit f7f9a9d into payjoin:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants