-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add favicon and another experimental warning #49
Conversation
b2f047e
to
7477522
Compare
<title>nolooking // Lightning PayJoin</title> | ||
</head> | ||
<body dark-mode> | ||
<br> | ||
<br> | ||
<header class="center"> | ||
<h1>👻 Lightning PayJoin 👻</h1> | ||
<a href="https://nolooking.chaincase.app/" target="_blank" style="text-decoration:none"><h1>👻 Lightning PayJoin 👻</h1></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this makes me realize 👻 Lightning PayJoin 👻
is messy. Should be <span class="h1">👻 <h1>Lightning PayJoin</h1> 👻</span>
for proper semantics with the --h1
css variables, but it's past halloween anyway to get rid of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't manage to make this change without getting them onto new lines
static/index.html
Outdated
@@ -58,6 +59,7 @@ <h2>Queue batches of lightning channels to open in a single transaction</h2> | |||
</div> | |||
<output id="queued" class="invisible"> | |||
<h2>PayJoin here to open these channels</h2> | |||
<code style="text-align: center;">⚠ This software is still extremely experimental and has not been vetted, use at your own risk ⚠</code> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not code. best to save semantic elements for semantics and use styles to apply styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True lazy mans HTML 😅
i love the default code style ahaha, abuse it on so many sites
Will resolve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it <code>
just font-family: monospace
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It adds border and some other cool styling (put important bits in .warning
css class)
ghost seems seasonal. Can we use the umbrel app icon.svg for favicon? |
Favicons based on umbrel icon: favicon_package_v0.16.zip |
69b75b4
to
84aaddc
Compare
84aaddc
to
9c0aed5
Compare
9c0aed5
to
43aeafd
Compare
No description provided.