Switch to use pkg-config to detect libevent and openssl #27
Conversation
Switching to pkg-config fixes a number of problems when detecting the libraries. For example the detection of libpthread was failing, because libevent_threads was added to LIBS before libevent itself, causing the libpthread test to fail due to missing symbols. pkg-config is anyway nowadays the preferred way for detecting libraries. It also has the benefit of working properly in static library situations. Signed-off-by: Thomas Petazzoni <[email protected]>
|
Hello, I googled for an email address / homepage to contact payden about my pull request #28. However it seems like he has died recently http://www.meaningfulfunerals.net/fh/obituaries/obituary.cfm?o_id=2723507&fh_id=10680 :( At least the name and place of residence is the same, and it mentions him being a software engineer. Just thought I'd give you a heads up. |
|
@JoakimSoderberg Thanks for the heads up. Apparently, there is a fork at https://github.com/JonnyWhatshisface/libwebsock, whose description explicitly indicate that the fork was done following the death of Payden. |
|
Yes I noticed this as well after writing to you from reading #26. As I mentioned there, it would have been better to simply fork this repo instead of restarting an entirely new repo. Especially since there's loads more people favoriting and having forked this repo. It just creates more hazzle, instead of simply changing the pull request target. |
Switching to pkg-config fixes a number of problems when detecting the
libraries. For example the detection of libpthread was failing,
because libevent_threads was added to LIBS before libevent itself,
causing the libpthread test to fail due to missing symbols. pkg-config
is anyway nowadays the preferred way for detecting libraries. It also
has the benefit of working properly in static library situations.
Signed-off-by: Thomas Petazzoni [email protected]