Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EP-26 Implemented container properties and made it properly refresh #8

Merged
merged 1 commit into from
Apr 18, 2019
Merged

EP-26 Implemented container properties and made it properly refresh #8

merged 1 commit into from
Apr 18, 2019

Conversation

arjantijms
Copy link
Contributor

No description provided.

@arjantijms arjantijms added this to the 1.0 milestone Apr 17, 2019
MarkWareham
MarkWareham approved these changes Apr 18, 2019
View reviewed changes
Copy link

@MarkWareham MarkWareham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with eclipse plugin so not really looked at the architecture. Can't see anything that stands out.

@arjantijms arjantijms merged commit 6dc5547 into payara:master Apr 18, 2019
Pandrex247
Pandrex247 approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, though not my area of expertise

@arjantijms arjantijms deleted the EP-26-libraries branch April 23, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkWareham MarkWareham MarkWareham approved these changes

@Pandrex247 Pandrex247 Pandrex247 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arjantijms @Pandrex247 @MarkWareham