FISH-9771 FISH-9688 spot bugs random only used once

[NotedSalmon]

Used SecurityUtils to generate a random and use it within the respective classes. Spot bugs issue. (check description)

Description

Spotbugs warning:

Random object created and used only once in com.sun.enterprise.admin.cli.cluster.ImportSyncBundleCommand.backupInstanceDir()

This code creates a java.util.Random object, uses it to generate one random number, and then discards the Random object. This produces mediocre quality random numbers and is inefficient. If possible, rewrite the code so that the Random object is created once and saved, and each time a new random number is required invoke a method on the existing Random object to obtain it.

If it is important that the generated Random numbers not be guessable, you must not create a new Random for each random number; the values are too easily guessable. You should strongly consider using a java.security.SecureRandom instead (and avoid allocating a new SecureRandom for each random number needed).random objects.

Important Info

Blockers

Testing

New tests

Testing Performed

built payara and ran spotbugs against the changes made.

Testing Environment

Documentation

Notes for Reviewers

[aubi]

LGTM

[aubi]

LGTM