Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-9176 FISH-9193 FISH-9194 FISH-9195 Improvements from Spotbugs #6871

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

Viii3
Copy link
Member

@Viii3 Viii3 commented Aug 8, 2024

Description

  • Resolves 3 issues from Spotbugs
  • Resolves FISH-9176
    • FISH-9193
    • FISH-9194
    • FISH-9195

Important Info

Blockers

Testing

New tests

Testing Performed

  • Built the server and deployed clusterjsp.
  • Ran spotbugs and examined the reports to see the associated issues are no longer present.

Testing Environment

Maven version: 3.9.6
Java version: 11.0.23, vendor: Eclipse Adoptium
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"

Documentation

Notes for Reviewers

Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Viii3 Viii3 merged commit 354c20e into payara:main Aug 15, 2024
1 check passed
@Viii3 Viii3 deleted the FISH-9176-Spotbugs branch September 3, 2024 08:42
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request Sep 16, 2024
FISH-9176 FISH-9193 FISH-9194 FISH-9195 Improvements from Spotbugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants