Fish-7158: adding warmup option to start domain #6451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge, still testing and documenting |
|
Verified on Linux, OpenJDK 11 I tried also postbootcommandfile: With content: The app was successfully deployed and after normal startup, it was running. After the cosmetic fixes this PR can be approved. |
|
Jenkins test please |
…warmup-option-to-start-domain
|
Jenkins test please |
I already tested same on windows 11 with azul JDK 11, and is working fine |
|
Jenkins test please |
aubi
requested changes
Oct 17, 2023
nucleus/admin/launcher/src/main/java/com/sun/enterprise/admin/launcher/GFLauncherInfo.java
Outdated
Show resolved
Hide resolved
nucleus/admin/launcher/src/main/java/com/sun/enterprise/admin/launcher/GFLauncherInfo.java
Outdated
Show resolved
Hide resolved
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding warmup option to stop server after bootstrapping
Description
This is a feature to replicate same functionality from payara micro to payara server with the start-domain command
Important Info
Blockers
Testing
New tests
Testing Performed
Manual testing, the server stops after bootstrapping
message from logs:
`
payara6/bin$ ./asadmin start-domain --warmup
Waiting for domain1 to start .......
Successfully started the domain : domain1
domain Location: /home/alfv83/projects/Payara/appserver/distributions/payara/target/stage/payara6/glassfish/domains/domain1
Log File: /home/alfv83/projects/Payara/appserver/distributions/payara/target/stage/payara6/glassfish/domains/domain1/logs/server.log
Admin Port: 4848
The server stops because warmup option was set to true.
You can reuse configuration because Server finishes after bootstrapping.
Command start-domain executed successfully.
`
Testing Environment
Windows 11 with azul JDK 11, maven 3.8.3 and Ubuntu 20.04 with azul JDK 11, maven 3.8.6
Documentation
Notes for Reviewers