FISH-7809 Remove 'deploy-internals' Profile and Fix Deployment of Core #6404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of Core, the deploy-internals profile becomes redundant. Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
|
Jenkins test please |
Pandrex247
requested review from
breakponchito,
luiseufrasio,
aubi and
abdulrahim458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the introduction of Core, the
deploy-internalsprofile becomes redundant.This also moves the deployment information from the
core-parentmodule to thecore-aggregatormodule, since otherwise deployment of Core would fail due to thecore-aggregatorandcore-bomnot knowing where to deploy to.The structure is now:
core-aggregator- contains deployment and distribution management information. Also sets thedeploy.skipproperty to false so that Core modules are deployed.core-parent- all deployment information removed. Should™ inherit fromcore-aggregatorcore-bom- Should™ inherit deployment information fromcore-aggregatorpayara-aggregator- Should™ inherit deployment information fromcore-aggregator. Also sets thedeploy.skipproperty to true so that the non-Core Server artefacts aren't deployed, and sets the deployment repository to payara-community.payara-bom,payara,payara-web,payara-ml,payara-web-ml,payara-micro,payara-embedded-all,payara-embedded-web) - sets thedeploy.skipproperty to falseThe intent is that Core modules get deployed to payara-artifacts, Server modules are not deployed at all, and Server distributions are deployed to payara-community. Snapshots for both Core and Server should end up in payara-snapshots.
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
mkdir D:\Downloads\FISH-7809mvn clean deploy -f core/pom.xml "-Dmaven.repo.local=D:\Downloads\FISH-7809"mvn clean deploy "-P!BuildCore,BuildEmbedded" "-Dmaven.repo.local=D:\Downloads\FISH-7809"fish.payara.distributions:payara:6.2023.10-SNAPSHOT- present 👍fish.payara.extras:payara-embedded-all:6.2023.10-SNAPSHOT- present 👍fish.payara.server.internal.extras:payara-micro-boot:6.2023.10-SNAPSHOT- not present 👍fish.payara.api:payara-api:6.2023.10-SNAPSHOT- only one snapshot present (implying it didn't get rebuilt and redeployed) 👍Testing Environment
Windows 11, Zulu JDK 11.0.20, Maven 3.9.4
Documentation
N/A
Notes for Reviewers
None