Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-5829 FISH-5830 GMBAL 4.0.3 and PFL 4.1.2 #5482

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

Pandrex247
Copy link
Member

@Pandrex247 Pandrex247 commented Nov 2, 2021

Description

Required component upgrades for JDK 17.
Also adds new System Property to default domain config.

For ORB compatibility with JDK11+ JDKs see eclipse-ee4j/orb-gmbal#22
In short, the ORB references com.sun.corba.ee.spi.orb.ORB, which references com.sun.corba.ee.impl.corba.TypeCodeFactory which eventually references com.sun.corba.ee.spi.legacy.connection.Connection.getSocket and java.net.Socket.checkPermission(java.net.SocketImpl).
Now SocketImpl contains a method "<S extends SocketImpl & PlatformSocketImpl> S createPlatformSocketImpl", which causes the ORB to crash completely. Setting a system property with this string ignores the fact GMBAL doesn't support multiple upper bounds.

Important Info

Blockers

None.

Testing

New tests

None.

Testing Performed

Ran the Payara - ejb-invoker Secure Endpoint test against JDK 8 - worked
Ran the Payara - ejb-invoker Secure Endpoint test against JDK 8 with the property deleted - worked
Ran the Payara - ejb-invoker Secure Endpoint test against JDK 11 - worked
Ran the Payara - ejb-invoker Secure Endpoint test against JDK 11 with the property deleted - worked

Running ejb-invoker Secure Endpoint test against JDK 17 requires additional commits related to EJB security, not tied to Gmbal:

Testing Environment

Windows 10, Zulu JDK 8u312, 11.0.13, and 17.0.1

Documentation

N/A

Notes for Reviewers

If you want to test against JDK 17, you'll likely need to grab all of my other PRs since the server won't even start on JDK 17 till those are merged. See my mega-branch here: https://github.com/Pandrex247/Payara/commits/FISH-5540

@Pandrex247
Copy link
Member Author

Jenkins test please

@Pandrex247
Copy link
Member Author

Jenkins test please

Copy link
Contributor

@aubi aubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JamesHillyard JamesHillyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright needs updating on:

  • nucleus/packager/nucleus-corba-base/pom.xml
  • appserver/orb/orb-iiop/pom.xml
  • appserver/admin/production_domain_template_web/src/main/resources/config/domain.xml
  • appserver/admin/production_domain_template/src/main/resources/config/domain.xml

Signed-off-by: Andrew Pielage <[email protected]>
@Pandrex247 Pandrex247 merged commit dcf3741 into payara:master Nov 3, 2021
@Pandrex247 Pandrex247 deleted the FISH-5829-FISH-5830 branch November 3, 2021 09:33
JamesHillyard pushed a commit to JamesHillyard/Payara that referenced this pull request Nov 18, 2021
FISH-5829 FISH-5830 GMBAL 4.0.3 and PFL 4.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants