-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FISH-5829 FISH-5830 GMBAL 4.0.3 and PFL 4.1.2 #5482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins test please |
Pandrex247
force-pushed
the
FISH-5829-FISH-5830
branch
from
November 2, 2021 12:33
8e1e5cc
to
b20eb5c
Compare
Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
Pandrex247
force-pushed
the
FISH-5829-FISH-5830
branch
from
November 2, 2021 12:34
b20eb5c
to
bd44541
Compare
Jenkins test please |
aubi
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright needs updating on:
- nucleus/packager/nucleus-corba-base/pom.xml
- appserver/orb/orb-iiop/pom.xml
- appserver/admin/production_domain_template_web/src/main/resources/config/domain.xml
- appserver/admin/production_domain_template/src/main/resources/config/domain.xml
Signed-off-by: Andrew Pielage <[email protected]>
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Nov 18, 2021
FISH-5829 FISH-5830 GMBAL 4.0.3 and PFL 4.1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required component upgrades for JDK 17.
Also adds new System Property to default domain config.
Important Info
Blockers
None.
Testing
New tests
None.
Testing Performed
Ran the Payara - ejb-invoker Secure Endpoint test against JDK 8 - worked
Ran the Payara - ejb-invoker Secure Endpoint test against JDK 8 with the property deleted - worked
Ran the Payara - ejb-invoker Secure Endpoint test against JDK 11 - worked
Ran the Payara - ejb-invoker Secure Endpoint test against JDK 11 with the property deleted - worked
Running ejb-invoker Secure Endpoint test against JDK 17 requires additional commits related to EJB security, not tied to Gmbal:
Testing Environment
Windows 10, Zulu JDK 8u312, 11.0.13, and 17.0.1
Documentation
N/A
Notes for Reviewers
If you want to test against JDK 17, you'll likely need to grab all of my other PRs since the server won't even start on JDK 17 till those are merged. See my mega-branch here: https://github.com/Pandrex247/Payara/commits/FISH-5540