-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming trim to enforce_schema in parse_m3u #13
Conversation
m3u_parser/m3u_parser.py
Outdated
line += ' tvg-language="{}"'.format(stream_info["language"]["name"]) | ||
if stream_info.get("category"): | ||
if "language" in stream_info: | ||
line += ' tvg-language="{}"'.format(stream_info["language"]["code"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dineiar Here I had kept the name and you replaced it with the code again ?? Any reason to do so ?? I followed the m3u files present here https://github.com/iptv-org/iptv/tree/master/channels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a mistake, sorry @pawanpaudel93. It should be fixed now (f34cd0d).
@dineiar If enforce_schema is set to True then for non-exising fields it will have None and if we save it to JSON it's fine but when we save it to m3u then it has "None" text for the non-existing fields. It's okay to have "None" in m3u ?? |
@pawanpaudel93, this is a side-effect of using In this PR I fixed it by using |
@dineiar Are you sure about what you are talking if it doesn't fill None when saving to m3u file with enforce_schema=True with "key" in stream_info ?? |
@pawanpaudel93, oh, I'm sorry, I was talking about using I just fixed that issue in 319a918. |
No description provided.