-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting pyodide version #67
Conversation
Awesome, thank you for the super fast PR! Looking at the existing code, I think |
Don't pay attention to CI failures, they're unrelated. |
Aha yeah, I was wondering why the old school % was used over format, but that's a good point! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect, thanks! Can you just confirm it actually works (since Pyodide was upgraded), and whether it fixes #66? 😄
Oh we'll need some docs, though I can take care of that if you're unsure about it. |
Yeah if you can handle docs that'd be great and let me test and report back soon... |
OK looks like it's working well, and the version upgrade also fixes #66. Thank you so much! |
Thanks! It seems to be working past the installation. However, I don't think it's rendering the Panel widgets. I might have to research a bit on https://github.com/holoviz-dev/nbsite/tree/main/nbsite/pyodide and see what's done differently. |
Closes #66
I probably am missing a few pieces.