This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
DEV: Use UppyUploadMixin for docked-upload #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the docked-upload to use the new UppyUploadMixin from discourse core; the old mixin is no longer supported. I also added some minor fixes around changed APIs for the docked-editor which inherits from d-editor and implements textarea-text-manipulation, without this fix the upload text would not be added.
martin-brennan
commented
Dec 14, 2021
| @@ -8,7 +8,10 @@ class QuickPostCooked extends PostCooked { | |||
| const $html = $(`<div class='cooked'>${this.attrs.cooked}</div>`); | |||
| this._insertQuoteControls($html); | |||
| this._showLinkCounts($html); | |||
| this._fixImageSizes($html); | |||
|
|
|||
| // removed inhttps://github.com/discourse/discourse/commit/e305365168528883872d4ce9efd109e41149ef0a | |||
There was a problem hiding this comment.
This was broken in main for this repo, I could not do this fix without commenting this out, a further fix will need to be made here (or it could possibly be removed altogether, I didn't look into it)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the docked-upload to use the new UppyUploadMixin
from discourse core; the old mixin is no longer supported.
I also added some minor fixes around changed APIs for the docked-editor
which inherits from d-editor and implements textarea-text-manipulation,
without this fix the upload text would not be added.