Skip to content

Commit

Permalink
fixed review comments
Browse files Browse the repository at this point in the history
Signed-off-by: tcchawla <[email protected]>
  • Loading branch information
tcchawla committed Jan 19, 2024
1 parent bb96166 commit 3276219
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 16 deletions.
15 changes: 1 addition & 14 deletions .github/workflows/test_arm64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,4 @@ jobs:
uses: ./.github/workflows/test_template.yaml
with:
runs-on: actuated-arm64-8cpu-8gb
targets: "['linux-arm64-unit-test-4-cpu-race']"

coverage:
needs:
- test-linux-arm64-cpu-race
runs-on: actuated-arm64-8cpu-8gb
steps:
- uses: actions/checkout@v4
- id: goversion
run: echo "goversion=$(cat .go-version)" >> "$GITHUB_OUTPUT"
- uses: actions/setup-go@v5
with:
go-version: "1.21.6"
- run: make test
targets: "['linux-arm64-unit-4-cpu-race']"
5 changes: 3 additions & 2 deletions .github/workflows/test_template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
targets:
required: false
type: string
default: "['linux-unit-test-1-cpu', 'linux-unit-test-4-cpu']"
default: "[]"
permissions: read-all

jobs:
Expand All @@ -27,14 +27,15 @@ jobs:
- env:
TARGET: ${{ matrix.target }}
run: |
go clean -testcache
case "${TARGET}" in
linux-amd64-unit-4-cpu-race)
GOARCH=amd64 PASSES='unit' RACE='true' CPU='4' ./scripts/test.sh -p=2
;;
linux-386-unit-1-cpu)
GOARCH=386 PASSES='unit' RACE='false' CPU='1' ./scripts/test.sh -p=4
;;
linux-arm64-unit-test-4-cpu-race)
linux-arm64-unit-4-cpu-race)
GOARCH=arm64 PASSES='unit' RACE='true' CPU='4' ./scripts/test.sh -p=2
;;
*)
Expand Down

0 comments on commit 3276219

Please sign in to comment.