Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing logs, adding comments. Better regex for for-loop var replace… #6

Merged
merged 1 commit into from
May 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ <h1>Just a demo!</h1>
<input type="text" value="${window.performance.now().toFixed(2)}" readonly>
</div>`
});
console.log(myTemplate);
console.log('Template created: ', myTemplate);
myTemplate.mountTo(document.getElementById('app'));
</script>
</body>
Expand Down
4 changes: 1 addition & 3 deletions src/module/template.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,11 @@ export default class Template {
let val = this.template.state[property];
Object.defineProperty.call(that, this._template.state, property, {
get() {
// console.log('Calling getter for ' + property, that);
return val;
},
set(value: any) {
// console.log('Calling setter for ' + property);
val = value;
that.update();
that.update(); // TODO check diff if update is necessary.
}
});
});
Expand Down
6 changes: 3 additions & 3 deletions src/parser/eval/evalDoEvent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
import { ITemplate } from '../../module/template';

/**
* TODO
* @param statement TODO
* @param context TODO
* Evaluate `event`-nodes.
* @param statement The statement that needs to be evaluated.
* @param context The context in which it gets used.
*/
const evalDoEvent = (statement: string, context: ITemplate) => {
const eventType = statement.split(':')[0];
Expand Down
22 changes: 10 additions & 12 deletions src/parser/eval/evalForNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,12 @@ import { ITemplate } from '../../module/template';
*/
const evalForNode = (forNode: HTMLSpanElement, condition: string, context: ITemplate): string => {
const multipliedChildren: string[] = [];

// TODO: Variable context.

Function(
'multipliedChildren', // The multiplied content of the for-node.
'innerHTML', // The content of the for-node.
'replaceLoopVarsInHTML', // Evaluate the inner appearances of the loop variable.
`let loopVar;
if(/^var |^let /.test('${condition}')){
console.log('${condition}'.slice('${condition}'.indexOf(' '), '${condition}'.indexOf('=')).trim());
loopVar = '${condition}'.slice(
'${condition}'.indexOf(' '),
'${condition}'.indexOf('=')
Expand All @@ -37,20 +33,22 @@ const evalForNode = (forNode: HTMLSpanElement, condition: string, context: ITemp
};

/**
* TODO
* @param loopVar TODO
* @param innerHTML TODO
* Find loop variables in HTML (e.g. $i, $xyz) and replace them with their actual value.
* @param loopVar The name of the variable.
* @param varValue The actual value of the variable.
* @param innerHTML The HTML that needs to be replaced.
*/
const replaceLoopVarsInHTML = (loopVar: string, varValue: number, innerHTML: string) => {
// TODO only replace the variables between mustaches {{ $i }}
/* const findVarRegex = /{{.*?(\$i).*?}}/g;
while (findVarRegex.test(innerHTML)) {
innerHTML.replace(findVarRegex, loopVar);
} */
// Naive solution, just replace:
while (innerHTML.indexOf('$' + loopVar) >= 0) {
innerHTML = innerHTML.replace('$' + loopVar, String(varValue));
}

// Fix this solution please:
/* const findVarRegex = /<do.*?js.*?>.*?(\$i).*?<\/do>/;
while (findVarRegex.test(innerHTML)) {
innerHTML = innerHTML.replace(findVarRegex, String(varValue));
} */
return innerHTML;
};

Expand Down
6 changes: 5 additions & 1 deletion src/parser/eval/evalJSNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

import { ITemplate } from '../../module/template';

// TODO impl.
/**
* Evaluate sandboxed `js`-expression nodes.
* @param statement The statement that gets evaluated.
* @param context The context in which it should be evaluated.
*/
const evalJSNode = (statement: string, context: ITemplate): string => {
// Evaluate state variable.
if (context.state.hasOwnProperty(statement)) {
Expand Down