Fix default headers (#105, #168) #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulvanbladel Should I be worried about the non passing CI checks? Looks like some misconfiguration in Travis tasks? |
|
no worries :) |
|
@paulvanbladel Done. I suggest updating the npm package as this can be considered a high impact hotfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests reverts the behaviour introduced in #105 and #168 that broke all multipart requests by setting the default Content-Type header to 'application/json', preventing the client to automatically calculating multipart data boundary.
This pull requests removes the default configuration in FetchConfig and instead, approaches the problem by explicitly setting the needed headers for each request in the library, so that the library does not interfere with host applications.