Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first version of deployment on dev script #17

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

minottic
Copy link
Collaborator

@minottic minottic commented Aug 5, 2022

@stephan271 , @wakonig this would be the first version of the deployment script. Unfortunately, I've checked the git client hooks and the post-push does not exist.

This script might change (depending on what you need). For now, the idea is that using this script, steps 1, 7, (8 partially) are automated.
This script has to be run from the scilog-ci folder, every time one wants to deploy.
It can be modified to run directly in the scilog (submodule) folder to cover points 2 and 6 (cd commands).

Let me know if it is good enough or needs changing.

@minottic minottic requested review from stephan271 and wakonig August 5, 2022 08:56
@stephan271
Copy link
Contributor

Did you think about the option to have no branches for scilog-ci for "normal" development updates ?

@minottic
Copy link
Collaborator Author

minottic commented Aug 5, 2022

I still haven't understood what the idea is on that...

@wakonig
Copy link

wakonig commented Aug 5, 2022

I guess the idea was to only have a single branch in scilog-ci and automatically deploy whatever is on main. We test locally, discuss the PR on git, merge it, test it on our dev server and potentially later deploy it on production.
By skipping the ci branches, it is always clear what is currently deployed on dev

@minottic
Copy link
Collaborator Author

minottic commented Aug 5, 2022

now the deployment has 3 steps: to dev, to qa, to prod. What you described is actually what happens in qa. I still struggle to understand what it simplifies, it only removes the PR opening need

@wakonig
Copy link

wakonig commented Aug 5, 2022

Okay, now I'm also confused... I understood that there is no automatic deployment from scilog main?

@minottic
Copy link
Collaborator Author

minottic commented Aug 5, 2022

everything it's more or less explained here: https://github.com/paulscherrerinstitute/scicat-ci/#scicat-ci (happy to discuss further ofc)

@minottic minottic force-pushed the deploy_script branch 3 times, most recently from f7e880e to bee4ece Compare August 17, 2022 14:31
@minottic minottic merged commit 7b3bab3 into main Aug 17, 2022
@minottic minottic deleted the deploy_script branch August 17, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants