Document commands to run in dev docker containers #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sbliven
commented
Nov 15, 2023
sbliven
commented
- Update README
- Simplify frontend dockerfile
Remove nginx stuff; if this is needed, use the production image
|
I should have closed it with this |
|
Looks like half this PR got merged already. I'm not sure how that happened, but I've merged from main and this should be the full changes. |
minottic
reviewed
Nov 17, 2023
| ``` | ||
|
|
||
| A custom Dockerfile is used because the production image uses the node alpine base image which does not crosscompile on macOS. | ||
| A custom Dockerfile is used because the production image builds the static site and then serves it via nginx. The development image serves the site using `ng serve` (webpack-dev-server) so it reflects the latest code and updates when files change. |
There was a problem hiding this comment.
does the official image work on your mac? Because the alpine version of node did not work on mac for me. If this is the case for you as well, I would keep the comment as is and also keep the custom image with stages and the docker-file with target
There was a problem hiding this comment.
nginx:1.2-alpine doesn't work on arm64. Newer versions of nginx do. We should update all our images to use a recent alpine version.
sbliven
added a commit
that referenced
this pull request
Jun 4, 2024
[Previous PR](#215) - Improve documentation of the commands to run in each container - Some minor fixes to docker-compose to support recent docker versions ## Squashed commits - Refactor fe dev Dockerfile Remove nginx stuff; if this is needed, use the production image - Document commands to run in dev containers - Fix be_next command in README - Document BE env vars - Fix docker-compose Recent docker versions don't support depends_on in base profiles used with extends
|
This has been rebased in #229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.