Allow request post and get to timeout #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resynch to the base master
Added the content-type to the tupla text/html;charset=utf-8
It looks like that the elog server is expecting to receive latin-1 encoded bytes but requests is sending the message a standard UTF-8 encoded string. To avoid this problem the message and the string attribute values are encoded in l1 before sending the request.
Capability to post and read back messages / attributes with special characters
…request. Update documentation. Add a test case to demonstrate the functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the requests documentation all production codes should implement a Timeout for all requests to avoid application hanging and freezing due to a unresponsive server.
I have added a timeout parameter to all methods invoking a post or get requests. The timeout is by default None, it means that the API structure is not modified, as proved in the test suite. In the test suite, I have added a test with a very short timeout to prove the functionality of the newly introduced feature.
When a timeout is occurring, a new elog exception is raised so that the API user can handle it.