Window closing implemented return glutin::ControlFlow::Break #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrouget
requested changes
Oct 2, 2017
| @@ -157,6 +157,13 @@ fn main() { | |||
| window.show(); | |||
|
|
|||
| event_loop.run_forever(|_event| { | |||
| match _event { | |||
There was a problem hiding this comment.
Rename _event to event.
Adding an underscore in from a variable means it's not used.
| @@ -157,6 +157,13 @@ fn main() { | |||
| window.show(); | |||
|
|
|||
| event_loop.run_forever(|_event| { | |||
| match _event { | |||
| glutin::Event::WindowEvent { event, .. } => match event { | |||
There was a problem hiding this comment.
Instead of event, you can directly write glutin::WindowEvent::Closed. Then you have one less match to use.
| @@ -157,6 +157,13 @@ fn main() { | |||
| window.show(); | |||
|
|
|||
| event_loop.run_forever(|_event| { | |||
| match _event { | |||
| glutin::Event::WindowEvent { event, .. } => match event { | |||
| glutin::WindowEvent::Closed => return glutin::ControlFlow::Break, | |||
There was a problem hiding this comment.
If you only have one match, the return is not necessary.
There was a problem hiding this comment.
Sorry but I can not fix it. I just started learning Rust. Rust By Example, or Book. Doesn't help here.
| glutin::WindowEvent::Closed => return glutin::ControlFlow::Break, | ||
| _ => (), | ||
| }, | ||
| _ => () |
There was a problem hiding this comment.
return glutin::ControlFlow::Continue here.
| // Will be use used by Servo later | ||
| let event_loop_waker = Box::new(GlutinEventLoopWaker { | ||
| let _event_loop_waker = Box::new(GlutinEventLoopWaker { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't realy understand what I am doing. But it works now. For me on Ubuntu 16.04